Please drop ENABLE_LIVEEDIT_SUPPORT and instead hide live edit behind the
flag
(flag-definitions.h) FLAG_live_edit. The use of the spy
I dropped ENABLE_LIVEEDIT_SUPPORT. However, I put it against
ENABLE_DEBUGGER_SUPPORT instead.
Please confirm if you would like to have it without any conditions.
I probably should use FLAG_live_edit as a possible TODO.
Until now I have no code anywhere, that may use this flag.
Any new functionality is activated only on script changing time. So I can
only
use this flag to block LiveEdit API, which doesn't seem necessary (just do
not
call it).
When adding new files please update the other build systems as well.
Updating
tools/gyp/v8.gyp is required for Chromium build. And if possibly also
update
files in tools/v8.xcodeproj and tools/visual_studio.
Right.
I did all files except tools/v8.xcodeproj similarly to some other change.
Will consult some roommate tomorrow about tools/v8.xcodeproj which can't
seem to
be human-editable.
http://codereview.chromium.org/607004/diff/10/1015
File src/liveedit.cc (right):
http://codereview.chromium.org/607004/diff/10/1015#newcode65
src/liveedit.cc:65: : listener_(active_function_info_listener)
On 2010/02/16 09:40:09, Søren Gjesse wrote:
Is the member listener_ actually required?
Not really. I just prefer to minimize my dependencies on global
variable.
I removed the field. However, I'm not sure it will decrease the size of
Spy class currently.
http://codereview.chromium.org/607004/diff/10/1015#newcode86
src/liveedit.cc:86: bool LiveEditFunctionSpy::IsActive() {
On 2010/02/16 09:40:09, Søren Gjesse wrote:
How about making this inline this and use it in the functions above
(replacing
listener_ != NULL)?
I don't know. In the current state it will probably make it just more
indirect: you still access pointer explicitly, but you check whether
it's null implicitly.
Should we do this later, if IsActive gets some additional semantics?
http://codereview.chromium.org/607004/diff/10/1016
File src/liveedit.h (right):
http://codereview.chromium.org/607004/diff/10/1016#newcode50
src/liveedit.h:50: //
On 2010/02/16 09:40:09, Søren Gjesse wrote:
Please remove this feature request comment.
Done.
http://codereview.chromium.org/607004/diff/10/1016#newcode76
src/liveedit.h:76: class LiveEditFunctionSpy {
On 2010/02/16 09:40:09, Søren Gjesse wrote:
How about changing Spy to Tracker, or something like this.
Tracker is fine.
Done
http://codereview.chromium.org/607004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
