I'll take a look and see if I have any comments. I think it's fine to commit based on Søren's LGTM.
On Wed, Feb 17, 2010 at 9:48 AM, <[email protected]> wrote: > LGTM > > I can see a flag does not make much sense. > > Regarding the xcode project there is a tool in the Chromium repository > under > src/tools/xcodebodge which can update xcode project files. If you can't > make > that work you can leave the xcode project for now. > > > > http://codereview.chromium.org/607004/diff/6001/5003 > File src/codegen.cc (right): > > http://codereview.chromium.org/607004/diff/6001/5003#newcode238 > src/codegen.cc:238: #ifdef ENABLE_DEBUGGER_SUPPORT > I think we should loose the #ifdef/#endif here as without live edit > enabled this should be very light weight. The #ifdef > ENABLE_DEBUGGER_SUPPORT is mainly used to produce a smaller binary, and > here I think it clutters the code without saving much in the size of the > binary. > > http://codereview.chromium.org/607004/diff/6001/5004 > File src/compiler.cc (right): > > http://codereview.chromium.org/607004/diff/6001/5004#newcode120 > src/compiler.cc:120: #ifdef ENABLE_DEBUGGER_SUPPORT > Looks as if this is not used. It is just a duplicate of MakeCode. > > http://codereview.chromium.org/607004/diff/6001/5005 > File src/compiler.h (right): > > http://codereview.chromium.org/607004/diff/6001/5005#newcode226 > src/compiler.h:226: > Where is this function used? > > http://codereview.chromium.org/607004/diff/6001/5006 > File src/full-codegen.cc (right): > > http://codereview.chromium.org/607004/diff/6001/5006#newcode451 > src/full-codegen.cc:451: MacroAssembler masm(NULL, kInitialBufferSize); > Also drop #ifdef/#endif here > > > http://codereview.chromium.org/607004 > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
