PTAL. I have uploaded an updated CL which uses a macro as suggested. That
made
it possible to revert the changes to the parts of runtime code which were
using
.forEach().
https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js
File src/debug/liveedit.js (right):
https://codereview.chromium.org/1309243003/diff/1/src/debug/liveedit.js#newcode219
src/debug/liveedit.js:219: for (var j = 0; j <
update_positions_list[i].live_shared_function_infos.length; j++) {
On 2015/09/08 07:10:34, cbruni wrote:
Did you change this on purpose? Seems unrelated to your fix.
Now that I am changing the code to use a macro I can revert this change
and leave the code as it was.
https://codereview.chromium.org/1309243003/diff/1/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/1309243003/diff/1/src/object-observe.js#newcode696
src/object-observe.js:696: for (var i = 0; i <
$observeObjectMethods.length; i++)
On 2015/09/08 07:10:34, cbruni wrote:
I presume these are accidental changes?
Same here, now with the macro is possible to avoid this change.
https://codereview.chromium.org/1309243003/diff/1/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1309243003/diff/1/src/runtime.js#newcode717
src/runtime.js:717: function ToLengthFlagged(arg) {
On 2015/09/08 07:18:07, cbruni wrote:
I would create a TO_LENGTH macro out of this (see src/macros.py).
Acknowledged.
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
