On 2015/09/10 17:46:05, Dan Ehrenberg wrote:
lgtm
Code looks good to me. I am still worried about performance though. Could
you
run some benchmarks which hit the path before committing? Either that or
be
prepared to back it out later when the regression becomes apparent.
I have run some benchmarks and commented here:
https://code.google.com/p/v8/issues/detail?id=3087#c30
As long as --harmony-tolength is disabled by default, there will be no
observable
performance regression. There are some tweaks we can done to improve
performance
of ToLength, and once those are in we could remove the flag and always use
ToLength.
If nobody against before tomorrow morning (CEST morning :D), I will tell
the CQ
to
apply this patch by then, and I will be around the whole day in case it
might
need
to be reverted.
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
