Probably fine like this... but I was just reminded that an earlier
introduction
of toLength caused a serious performance regression on Regexp, so we do
have to
be careful. Only that the Array functions are not that prone to this as the
fast
paths are implemented in C++.
https://codereview.chromium.org/1309243003/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1309243003/diff/40001/src/heap/heap.h#newcode264
src/heap/heap.h:264: V(harmony_unicode_regexps_string,
"harmony_unicode_regexps") \
Are these here on purpose?
https://codereview.chromium.org/1309243003/diff/40001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1309243003/diff/40001/src/macros.py#newcode150
src/macros.py:150: macro TO_LENGTH(arg) = (harmony_tolength ?
$toLength(arg) : TO_UINT32(arg));
With the possibility of being annoying... maybe we could change the
macro name to reflect that it might change behavior depending on a flag.
For instance TO_LENGHT_OR_UINT32?
There has been some controversy among my colleagues on how to nicely
implement this change :)
https://codereview.chromium.org/1309243003/diff/40001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/1309243003/diff/40001/src/object-observe.js#newcode696
src/object-observe.js:696: var removePrototypeFn = function (f, i) {
DAT space :D
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
