Changed macro name, also removed the bogus patch hunks from the rebase.
PTAL.
https://codereview.chromium.org/1309243003/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1309243003/diff/40001/src/heap/heap.h#newcode264
src/heap/heap.h:264: V(harmony_unicode_regexps_string,
"harmony_unicode_regexps") \
On 2015/09/09 13:51:16, cbruni wrote:
Are these here on purpose?
Ouch, leftovers from rebasing, I'll remove them.
https://codereview.chromium.org/1309243003/diff/40001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1309243003/diff/40001/src/macros.py#newcode150
src/macros.py:150: macro TO_LENGTH(arg) = (harmony_tolength ?
$toLength(arg) : TO_UINT32(arg));
On 2015/09/09 13:51:16, cbruni wrote:
With the possibility of being annoying... maybe we could change the
macro name
to reflect that it might change behavior depending on a flag. For
instance
TO_LENGHT_OR_UINT32?
There has been some controversy among my colleagues on how to nicely
implement
this change :)
Ack. I don't mind changing the name. Reviews with nits are fine as long
as there are progress and everybody is happy with the final version of
the patch :)
https://codereview.chromium.org/1309243003/diff/40001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/1309243003/diff/40001/src/object-observe.js#newcode696
src/object-observe.js:696: var removePrototypeFn = function (f, i) {
On 2015/09/09 13:51:16, cbruni wrote:
DAT space :D
Acknowledged.
https://codereview.chromium.org/1309243003/diff/40001/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/1309243003/diff/40001/src/runtime.js#oldcode656
src/runtime.js:656:
Also, I noticed this bogus line removal here. I'm nuking it.
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
