On 2015/11/20 19:49:48, adamk wrote:
Having read through a few times, I have some high-level questions:
- You mentioned on IRC that the keeping-track-of-assigments-to-rewrite
thing
didn't interact well with something else. Was that resolved? Overall, do
you
know of any cases where this doesn't work correctly?
I believe that was resolved --- the last issues are the ones mentioned in my
previous comment.
- It seems a bit strange that the AssignmentPattern AST node subsumes the
entire
Assignment. This makes the code in full-codegen look odd, since only the
target
is visited and not the value. Was there a reason you didn't put more of
this
logic in Assignment?
The AssignmentPattern node is basically a stand-in for the rewritten
expression.
It's unfortunate that it's done this way, but since the Parser is doing the
desugaring, I'm not sure of a better way to do it.
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
