So, there are still some mixups in the AST visitors, and it would probably
be a
good idea to get feedback on the design just to make sure I actually
understood
what you were asking for.
https://codereview.chromium.org/1309813007/diff/410001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1309813007/diff/410001/src/ast-expression-visitor.cc#newcode268
src/ast-expression-visitor.cc:268:
RETURN_IF_VISIT_NODE(expr->destructuring_assignment());
One of these isn't needed, and I'm not sure which makes more sense
https://codereview.chromium.org/1309813007/diff/410001/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/1309813007/diff/410001/src/ast-numbering.cc#newcode352
src/ast-numbering.cc:352:
RETURN_IF_VISIT_NODE(node->destructuring_assignment());
Should this happen before IncrementNodeCount(), or after?
https://codereview.chromium.org/1309813007/diff/410001/src/full-codegen/x64/full-codegen-x64.cc
File src/full-codegen/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/1309813007/diff/410001/src/full-codegen/x64/full-codegen-x64.cc#newcode1769
src/full-codegen/x64/full-codegen-x64.cc:1769:
RETURN_IF_VISIT_NODE(expr->destructuring_assignment());
Unfortunately, even with the removed AST node, this still means adding
little bits like this to every VisitAssignment() in the tree
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
