Overall I really do prefer putting this stuff in Assignment. A few questions
about other additions, but I think this is on the right track.
https://codereview.chromium.org/1309813007/diff/410001/src/expression-classifier.h
File src/expression-classifier.h (right):
https://codereview.chromium.org/1309813007/diff/410001/src/expression-classifier.h#newcode165
src/expression-classifier.h:165: void RecordExpressionError(const
Scanner::Location& loc,
Was this added as a cleanup or to fix something that was broken before?
https://codereview.chromium.org/1309813007/diff/410001/src/full-codegen/x64/full-codegen-x64.cc
File src/full-codegen/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/1309813007/diff/410001/src/full-codegen/x64/full-codegen-x64.cc#newcode1769
src/full-codegen/x64/full-codegen-x64.cc:1769:
RETURN_IF_VISIT_NODE(expr->destructuring_assignment());
On 2015/11/24 18:06:39, caitp wrote:
Unfortunately, even with the removed AST node, this still means adding
little
bits like this to every VisitAssignment() in the tree
To my eyes that's a definite improvement: you're effectively replacing
the assignment with a different expression, so any visit to the
assignment's target/value should be replaced by a visit to the
destructured expression.
https://codereview.chromium.org/1309813007/diff/410001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1309813007/diff/410001/src/parser.h#newcode1065
src/parser.h:1065: ASSIGNMENT_INITIALIZER
Was this added to fix the mentioned test262 tests? If so can you give an
example of what it fixes?
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
