On 2015/11/20 23:16:55, adamk wrote:
https://codereview.chromium.org/1309813007/diff/350001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1309813007/diff/350001/src/flag-definitions.h#newcode678
src/flag-definitions.h:678: DEFINE_BOOL(parallel_compaction, true, "use
parallel
compaction")
On 2015/11/20 23:10:25, caitp wrote:
> On 2015/11/20 22:42:58, adamk wrote:
> > Looks like a stray change here
>
> It's from a rebase, so not everything in the inter diff is mine
This shows up in the whole diff, not the interdiff.
I think that's just the way Rietveld is, it's still a diff against the base
revision of the patch, so weird stuff shows up after a rebase. This stuff
was
added in CLs by other people from last week, and it just shows up here
because
it wasn't in the original base revision. In any case, I'll do another
rebase and
see if I can make the impl look cleaner to you (I'm fairly sure it's still
going
to look like a hack though)
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
