Interesting stuff! A few random drive-by comments.
http://codereview.chromium.org/619005/diff/6030/6032 File src/conversions.cc (right): http://codereview.chromium.org/619005/diff/6030/6032#newcode392 src/conversions.cc:392: decimal_rep = &grisu_buffer[0]; You can just write: decimal_rep = grisu_buffer; http://codereview.chromium.org/619005/diff/6030/6033 File src/grisu3.cc (right): http://codereview.chromium.org/619005/diff/6030/6033#newcode129 src/grisu3.cc:129: // Remark: this procedure takes into account the imprecission of its input Typo: -> precision http://codereview.chromium.org/619005/diff/7002/7007 File src/cached_powers.h (right): http://codereview.chromium.org/619005/diff/7002/7007#newcode40 src/cached_powers.h:40: #define GRISU_CACHE_STRUCT CachedPower No reason for this macro? http://codereview.chromium.org/619005/diff/7002/7007#newcode43 src/cached_powers.h:43: #define GRISU_CACHE_OFFSET kCachedPowerOffset No reason for this macro either. http://codereview.chromium.org/619005/diff/7002/7007#newcode44 src/cached_powers.h:44: #define GRISU_UINT64_C V8_2PART_UINT64_C And this one. http://codereview.chromium.org/619005/diff/7002/7007#newcode50 src/cached_powers.h:50: #define COMPUTE_FOR_CACHE(i) \ If this is performance-critical make an inline function, not a macro. http://codereview.chromium.org/619005/diff/7002/7007#newcode76 src/cached_powers.h:76: if (!found && (gamma - alpha + 1 >= GRISU_CACHE_MAX_DISTANCE(8))) { Remove. This is the same as: COMPUTE_FOR_CACHE(8) which you have already below. http://codereview.chromium.org/619005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
