The .h files do not seem to follow V8 (and Google) standards. Any suggestions on
improving that?
I could create -inl.h files, but I'm not really sure that would help much.


http://codereview.chromium.org/619005/diff/6030/6032
File src/conversions.cc (right):

http://codereview.chromium.org/619005/diff/6030/6032#newcode392
src/conversions.cc:392: decimal_rep = &grisu_buffer[0];
On 2010/02/22 16:25:24, fschneider wrote:
You can just write: decimal_rep = grisu_buffer;

Done.

http://codereview.chromium.org/619005/diff/6030/6033
File src/grisu3.cc (right):

http://codereview.chromium.org/619005/diff/6030/6033#newcode129
src/grisu3.cc:129: // Remark: this procedure takes into account the
imprecission of its input
On 2010/02/22 16:25:24, fschneider wrote:
Typo: -> precision

Done.

http://codereview.chromium.org/619005

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to