http://codereview.chromium.org/2878043/diff/1/2 File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/2878043/diff/1/2#newcode448 src/arm/assembler-arm.cc:448: bool Assembler::IsStrRegisterImmediate(Instr instr) { Should the name indicate this only returns true for word store? (not byte or halfword) http://codereview.chromium.org/2878043/diff/1/4 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2878043/diff/1/4#newcode6361 src/arm/codegen-arm.cc:6361: __ mov(scratch0, Operand(Factory::null_value())); On ARM it should probably be LoadRoot(scratch0, Heap::kNullValueRootIndex); http://codereview.chromium.org/2878043/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
