http://codereview.chromium.org/2878043/diff/1/2 File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/2878043/diff/1/2#newcode448 src/arm/assembler-arm.cc:448: bool Assembler::IsStrRegisterImmediate(Instr instr) { On 2010/07/21 14:51:15, Rodolph Perfetta wrote:
Should the name indicate this only returns true for word store? (not
byte or
halfword)
We could do that. I chose this name because it matches the assembler name for the 'str' instruction. We have 'strb' and 'strh' for byte and halfword and could add IsStrb and IsStrh methods as well if needed. http://codereview.chromium.org/2878043/diff/1/4 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2878043/diff/1/4#newcode6361 src/arm/codegen-arm.cc:6361: __ mov(scratch0, Operand(Factory::null_value())); On 2010/07/21 14:51:15, Rodolph Perfetta wrote:
On ARM it should probably be LoadRoot(scratch0,
Heap::kNullValueRootIndex); Normally, yes. In this specific case I actually want a null_value instance in the constant pool so I can patch it to the address of a map at runtime. http://codereview.chromium.org/2878043/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
