http://codereview.chromium.org/3156028/diff/6002/12003 File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3156028/diff/6002/12003#newcode1501 src/arm/macro-assembler-arm.cc:1501: On 2010/08/18 14:25:10, Kasper Lund wrote:
Extra newline here.
Done. http://codereview.chromium.org/3156028/diff/6002/12011 File src/objects-inl.h (right): http://codereview.chromium.org/3156028/diff/6002/12011#newcode2749 src/objects-inl.h:2749: return reinterpret_cast<Code*>( On 2010/08/18 14:25:10, Kasper Lund wrote:
Hmm. This looks like it could be the same as code() - which is
prettier, but
maybe you should change code() to use a Code::cast(...) instead of the reinterpret_cast<Code*>().
Yes, changed unchecked_code to the code version and used Code::cast in code(). http://codereview.chromium.org/3156028/diff/6002/12013 File src/objects.h (right): http://codereview.chromium.org/3156028/diff/6002/12013#newcode3714 src/objects.h:3714: // through pointers to the first instruction int the code object. On 2010/08/18 14:25:10, Kasper Lund wrote:
int => in
Done. http://codereview.chromium.org/3156028/diff/6002/12018 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/3156028/diff/6002/12018#newcode592 src/x64/macro-assembler-x64.cc:592: On 2010/08/18 14:25:10, Kasper Lund wrote:
Extra newline.
Done. http://codereview.chromium.org/3156028/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
