some additional nitpicking
http://codereview.chromium.org/3156028/diff/23001/24011 File src/objects-inl.h (right): http://codereview.chromium.org/3156028/diff/23001/24011#newcode2406 src/objects-inl.h:2406: Object* Code::GetObjectFromEntryAddress(Address entry) { Name 'entry' is slightly confusing because it is not entry address but address of location where entry address is stored. http://codereview.chromium.org/3156028/diff/23001/24011#newcode2741 src/objects-inl.h:2741: Address entry = You can implement code() as return Code::cast(unchecked_code()); do avoid code duplication. http://codereview.chromium.org/3156028/diff/23001/24011#newcode2751 src/objects-inl.h:2751: HeapObject::FromAddress(entry - Code::kHeaderSize)); Can you use GetObjectFromEntryAddress here? http://codereview.chromium.org/3156028/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
