LGTM. Shouldn't it be possible to simplify the builtin function/code tables
and
only have the functions again?
http://codereview.chromium.org/3156028/diff/6002/12003
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3156028/diff/6002/12003#newcode1501
src/arm/macro-assembler-arm.cc:1501:
Extra newline here.
http://codereview.chromium.org/3156028/diff/6002/12011
File src/objects-inl.h (right):
http://codereview.chromium.org/3156028/diff/6002/12011#newcode2749
src/objects-inl.h:2749: return reinterpret_cast<Code*>(
Hmm. This looks like it could be the same as code() - which is prettier,
but maybe you should change code() to use a Code::cast(...) instead of
the reinterpret_cast<Code*>().
http://codereview.chromium.org/3156028/diff/6002/12013
File src/objects.h (right):
http://codereview.chromium.org/3156028/diff/6002/12013#newcode3714
src/objects.h:3714: // through pointers to the first instruction int the
code object.
int => in
http://codereview.chromium.org/3156028/diff/6002/12018
File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/3156028/diff/6002/12018#newcode592
src/x64/macro-assembler-x64.cc:592:
Extra newline.
http://codereview.chromium.org/3156028/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
