LGTM

http://codereview.chromium.org/3156028/diff/23001/24014
File src/serialize.cc (right):

http://codereview.chromium.org/3156028/diff/23001/24014#newcode866
src/serialize.cc:866: ONE_PER_SPACE(kNewObject, kPlain,
kFirstInstruction)
It's a bit wasteful in terms of V8's exe size to have a case per space
here when only two spaces can be involved (code and large code).  Might
be worth trying ALL_SPACES instead or if that impacts startup speed
making a new ONE_PER_CODE_SPACE.

http://codereview.chromium.org/3156028/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to