http://codereview.chromium.org/7477045/diff/59001/src/heap.cc File src/heap.cc (right):
http://codereview.chromium.org/7477045/diff/59001/src/heap.cc#newcode2651 src/heap.cc:2651: !ConsString::cast(buffer)->first()->IsSeqString())) || nit: please, indent this line for proper grouping http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc#newcode3415 src/ia32/code-stubs-ia32.cc:3415: __ cmp(Operand(ebx), Immediate(kConsStringTag)); technically you can save an instruction here (and most probably on other platforms too): if you cmp vs. kExternalString tag, then on eq you bailout, if greater you've got a splice and if lesser you've got a cons. http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc#newcode4890 src/ia32/code-stubs-ia32.cc:4890: __ and_(result_, kStringRepresentationMask); ditto here for shorter dispatch sequence http://codereview.chromium.org/7477045/diff/59001/src/ia32/regexp-macro-assembler-ia32.cc File src/ia32/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/ia32/regexp-macro-assembler-ia32.cc#newcode1104 src/ia32/regexp-macro-assembler-ia32.cc:1104: if (subject_tmp->IsAsciiRepresentation() != is_ascii) { if string might have changed, shouldn't you refetch subject_tmp? http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc#newcode2377 src/x64/code-stubs-x64.cc:2377: __ Set(r14, 0); maybe use arg1? http://codereview.chromium.org/7477045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
