Please take another look.
http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc#newcode3415 src/ia32/code-stubs-ia32.cc:3415: __ cmp(Operand(ebx), Immediate(kConsStringTag)); On 2011/08/25 16:02:45, antonm wrote:
technically you can save an instruction here (and most probably on
other
platforms too): if you cmp vs. kExternalString tag, then on eq you
bailout, if
greater you've got a splice and if lesser you've got a cons.
Great observation. Thanks. http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc#newcode2377 src/x64/code-stubs-x64.cc:2377: __ Set(r14, 0); On 2011/08/25 16:02:45, antonm wrote:
maybe use arg1?
I don't quite follow. arg1 is not defined until way later. http://codereview.chromium.org/7477045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
