LGTM
http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc#newcode5444 src/arm/code-stubs-arm.cc:5444: __ nop(0); // Jumping as first instruction would crash the code generation. Is this a bug? http://codereview.chromium.org/7477045/diff/62001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7477045/diff/62001/src/ia32/code-stubs-ia32.cc#newcode3415 src/ia32/code-stubs-ia32.cc:3415: STATIC_ASSERT((kConsStringTag < kExternalStringTag)); Why do we need extra () here? If the assert macro requires them, let's fix the macro. http://codereview.chromium.org/7477045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
