[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

Mon, 29 Aug 2011 04:44:09 -0700 

On 2011/08/26 22:29:05, Vitaly Repeshko wrote:

LGTM



http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):



http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc#newcode5444

src/arm/code-stubs-arm.cc:5444: __ nop(0);  // Jumping as first  
instruction

would crash the code generation.
Is this a bug?



http://codereview.chromium.org/7477045/diff/62001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):



http://codereview.chromium.org/7477045/diff/62001/src/ia32/code-stubs-ia32.cc#newcode3415

src/ia32/code-stubs-ia32.cc:3415: STATIC_ASSERT((kConsStringTag <
kExternalStringTag));

Why do we need extra () here? If the assert macro requires them, let's  
fix the

macro.


Those two issues are addressed by
http://code.google.com/p/v8/issues/detail?id=1644
and
http://codereview.chromium.org/7776007/


http://codereview.chromium.org/7477045/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev






















					Reply via email to