Will LGTM with a test :) and the comment addressed.
http://codereview.chromium.org/8468016/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/8468016/diff/1/src/profile-generator.cc#newcode2476 src/profile-generator.cc:2476: isolate->global_handles()->IterateAllRoots(&enumerator); I'm a bit worried that by allocating handles we're creating new GC roots while traversing GC roots. It's probably better to save raw pointers with AssertNoAllocation first and then promote them to handles. http://codereview.chromium.org/8468016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
