LGTM
http://codereview.chromium.org/8468016/diff/4001/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): http://codereview.chromium.org/8468016/diff/4001/test/cctest/test-heap-profiler.cc#newcode898 test/cctest/test-heap-profiler.cc:898: TEST(NoHandleLeaks) { Can you also check that if there's a garbage global object at the time a snapshot is taken that it won't end up in the snapshot? http://codereview.chromium.org/8468016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
