On 2011/11/17 18:08:19, Vitaly Repeshko wrote:
LGTM
http://codereview.chromium.org/8468016/diff/4001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
http://codereview.chromium.org/8468016/diff/4001/test/cctest/test-heap-profiler.cc#newcode898
test/cctest/test-heap-profiler.cc:898: TEST(NoHandleLeaks) {
Can you also check that if there's a garbage global object at the time a
snapshot is taken that it won't end up in the snapshot?
Thanks!
In the urls extractor, we only walk over global handles to find global
objects.
I'm assuming that a "garbage global object" is the one that is already
detached
from roots, right? In this case we wouldn't encounter it, so I don't see a
point
in such a test.
http://codereview.chromium.org/8468016/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
