Now will LGTM with a test only :)
http://codereview.chromium.org/8468016/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/8468016/diff/1/src/profile-generator.cc#newcode2476 src/profile-generator.cc:2476: isolate->global_handles()->IterateAllRoots(&enumerator); On 2011/11/15 20:06:01, Vitaly Repeshko wrote:
I'm a bit worried that by allocating handles we're creating new GC
roots while
traversing GC roots. It's probably better to save raw pointers with AssertNoAllocation first and then promote them to handles.
Ah, never mind. We only traverse global handles here. http://codereview.chromium.org/8468016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
