https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc#newcode1435 src/profile-generator.cc:1435: stats_buffer.Add(time_interval.size = entries_size); It seems, you need to update the comment on PushHeapObjectsStats in v8-profiler.h https://chromiumcodereview.appspot.com/10086004/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10086004/diff/1/test/cctest/test-heap-profiler.cc#newcode732 test/cctest/test-heap-profiler.cc:732: entries_count_ += buffer[i+1]; Still not considering defining the stream structure somewhere in v8-profiler.h? This looks pretty unreadable. https://chromiumcodereview.appspot.com/10086004/diff/1/test/cctest/test-heap-profiler.cc#newcode827 test/cctest/test-heap-profiler.cc:827: CHECK_LT(0, stats_update.entries_size()); I think you can store the previous value of size and verify its relative changes. Otherwise, you are not testing enough. https://chromiumcodereview.appspot.com/10086004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
