https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc#newcode1382 src/profile-generator.cc:1382: entry_info.size = size; why do you need to update the size? If the size is different then it's probably a new object. If so we should get a new id for it. https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc#newcode1427 src/profile-generator.cc:1427: ++entries_count; you still don't need to increase the count on each iteration. https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.h#newcode729 src/profile-generator.h:729: EntryInfo(SnapshotObjectId id, Address addr, unsigned int size) padding? https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.h#newcode731 src/profile-generator.h:731: EntryInfo(SnapshotObjectId id, Address addr, unsigned int size, bool accessed) why not a default value for accessed? https://chromiumcodereview.appspot.com/10086004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
