On 2012/04/13 15:01:27, alexeif wrote:
https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc#newcode1382
src/profile-generator.cc:1382: entry_info.size = size;
why do you need to update the size? If the size is different then it's
probably
a new object. If so we should get a new id for it.
The both count and size fields are useful.
Also v8 has optimizations for specific use cases and can grow arrays in
place.
https://chromiumcodereview.appspot.com/10086004/diff/1/src/profile-generator.cc#newcode1427
src/profile-generator.cc:1427: ++entries_count;
you still don't need to increase the count on each iteration.
done
https://chromiumcodereview.appspot.com/10086004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
