https://chromiumcodereview.appspot.com/10086004/diff/1005/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10086004/diff/1005/src/profile-generator.cc#newcode1430 src/profile-generator.cc:1430: uint32_t entries_count = entry_info - start_entry_info; Are you sure this compiles on all platforms, for example, on 64-bit MSVC? https://chromiumcodereview.appspot.com/10086004/diff/1005/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10086004/diff/1005/test/cctest/test-heap-profiler.cc#newcode818 test/cctest/test-heap-profiler.cc:818: entries_size = stats_update.entries_size(); I'd transpose these two lines to reuse entries_size in the check statement. https://chromiumcodereview.appspot.com/10086004/diff/1005/test/cctest/test-heap-profiler.cc#newcode829 test/cctest/test-heap-profiler.cc:829: CHECK_LT(stats_update.entries_size(), entries_size); Transpose arguments, CHECK_LT -> CHECK_GT https://chromiumcodereview.appspot.com/10086004/diff/1005/test/cctest/test-heap-profiler.cc#newcode870 test/cctest/test-heap-profiler.cc:870: entries_size = stats_update.entries_size(); Also transpose lines https://chromiumcodereview.appspot.com/10086004/diff/1005/test/cctest/test-heap-profiler.cc#newcode871 test/cctest/test-heap-profiler.cc:871: // It were the array and it's buffer. nit: "It were" -> "There are", "it's" -> "its" https://chromiumcodereview.appspot.com/10086004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
