My main concern here is the lack of support on other platforms, specifically that the API silently fails on x64 and ARM.
https://chromiumcodereview.appspot.com/10706002/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/10706002/diff/1/include/v8.h#newcode3189 include/v8.h:3189: static void SetFunctionEntryHook(uintptr_t entry_hook); I am not sure exactly what the right thing to do is, but it seems a bit fragile that the call silently fails on x64 and ARM. https://chromiumcodereview.appspot.com/10706002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/10706002/diff/1/test/cctest/test-api.cc#newcode10900 test/cctest/test-api.cc:10900: "function foo(i) { return i * i; }" To test optimized code, you can for V8 to optimize a function the next time it gets called. You need to call OptimizeFunctionOnNextCall, take a look at the test case in "UndetectableOptimized" for an example of usage. Make sure that you called the unoptimized version of a function at least once before optimizing it, otherwise we won't have type information and will likely deopt immediately after optimizing, and you won't be testing what you think. https://chromiumcodereview.appspot.com/10706002/diff/1/tools/test-wrapper-gypbuild.py File tools/test-wrapper-gypbuild.py (right): https://chromiumcodereview.appspot.com/10706002/diff/1/tools/test-wrapper-gypbuild.py#newcode220 tools/test-wrapper-gypbuild.py:220: returncodes += subprocess.call([sys.executable, Why is this change needed? https://chromiumcodereview.appspot.com/10706002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
