Oh, and please note that this change is incomplete as-is, as it only
implements the ia32 variant of the code stub.


On Fri, Jun 29, 2012 at 3:43 PM, <[email protected]> wrote:

> PTAL - I moved to using a code stub to bridge the entry hook to a function
> with
> native calling conventions. I figure this can easily be supported and
> tested on
> all platforms/architectures?
> Does ARM have a high-resolution on-chip timer?
>
> Note that I don't think it makes sense to enable the profiling in absence
> of the
> rdtsc instruction on ia32/x64, where it has been fixed in late CPUs to
> make an
> excellent wall-clock timer. I'm not sure how I'd go about that, however.
> Also, I'm unsure about using the GetEntryHookLocation method to test for
> whether
> profiling is enabled. Maybe it would be better to expose another method
> IsProfilingEnabled or some such?
>
> https://chromiumcodereview.**appspot.com/10706002/<https://chromiumcodereview.appspot.com/10706002/>
>

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to