Thanks, a new patch coming up, unless you object to the API suggestion.
https://chromiumcodereview.appspot.com/10706002/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/10706002/diff/1/include/v8.h#newcode3189 include/v8.h:3189: static void SetFunctionEntryHook(uintptr_t entry_hook); On 2012/06/27 23:01:54, danno wrote:
I am not sure exactly what the right thing to do is, but it seems a
bit fragile
that the call silently fails on x64 and ARM.
Good point. Another thing that occurred to me is that there's no way to "stack" this API, e.g. it doesn't make sense to have multiple profilers active at the same time. How about having this function return bool, return true on success, and fail it on unsupported platforms as well as on setting any transition except to and from a NULL hook? https://chromiumcodereview.appspot.com/10706002/diff/1/tools/test-wrapper-gypbuild.py File tools/test-wrapper-gypbuild.py (right): https://chromiumcodereview.appspot.com/10706002/diff/1/tools/test-wrapper-gypbuild.py#newcode220 tools/test-wrapper-gypbuild.py:220: returncodes += subprocess.call([sys.executable, On 2012/06/27 23:01:54, danno wrote:
Why is this change needed?
Ah, sorry, this is an unrelated change. This is needed for the script to run on my machine, presumably because I don't have a python interpreter installed, and so a file with a .py suffix will not execute directly. Will move to a separate change. https://chromiumcodereview.appspot.com/10706002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
