[v8-dev] Re: Implements a new API to set a function entry hook for profiling. (issue 10706002)

[danno]

LGTM. If you fix the nits and double check the TODO, I can land this for  
you.

https://chromiumcodereview.appspot.com/10706002/diff/20008/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://chromiumcodereview.appspot.com/10706002/diff/20008/src/arm/code-stubs-arm.cc#newcode7565
src/arm/code-stubs-arm.cc:7565: if (frame_alignment > kPointerSize)
nit: in V8 we always surround if code that can't requires a line break
with {}

https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc#newcode10895
test/cctest/test-api.cc:10895: // TODO(siggi): Verify
return_addr_location.
Do you want to do something about the TODO?

https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc#newcode10947
test/cctest/test-api.cc:10947: // Nulling it should alwasy succeed.
nit: always

https://chromiumcodereview.appspot.com/10706002/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev