Comments addressed - thanks!
https://chromiumcodereview.appspot.com/10706002/diff/20008/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://chromiumcodereview.appspot.com/10706002/diff/20008/src/arm/code-stubs-arm.cc#newcode7565
src/arm/code-stubs-arm.cc:7565: if (frame_alignment > kPointerSize)
On 2012/07/12 15:23:11, danno wrote:
nit: in V8 we always surround if code that can't requires a line break
with {}
Done.
https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc#newcode10895
test/cctest/test-api.cc:10895: // TODO(siggi): Verify
return_addr_location.
On 2012/07/12 15:23:11, danno wrote:
Do you want to do something about the TODO?
I'd prefer to leave it in for now, if that's all right?
I figure that once I have entry hooks for code stubs, I should be able
to verify that the return address seen on foo/bar invocations refers to
code that I've seen before.
https://chromiumcodereview.appspot.com/10706002/diff/20008/test/cctest/test-api.cc#newcode10947
test/cctest/test-api.cc:10947: // Nulling it should alwasy succeed.
On 2012/07/12 15:23:11, danno wrote:
nit: always
Done.
https://chromiumcodereview.appspot.com/10706002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
