lgtm with nits
http://codereview.chromium.org/11365111/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/11365111/diff/1/src/objects.cc#newcode4074 src/objects.cc:4074: if (self->HasIndexedInterceptor()) { Maybe use (self->HasIndexedInterceptor() && mode != FORCE_DELETION) to reduce the number of paths. There is no need to set the mode to FORCE_DELETION if it is already FORCE_DELETION. Otherwise put { } around if/else branches. http://codereview.chromium.org/11365111/diff/1/src/objects.cc#newcode10230 src/objects.cc:10230: MaybeObject* result = *value; This initialization seems superfluous since it's overwritten directly afterwards. http://codereview.chromium.org/11365111/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
