Maybe you want to have another quick look -- the latest diff mostly removes
code. :)
I entirely removed the previous implementations of 2 largish HasElement...
methods and delegate to the new respective GetElementAttribute instead.
It's now
simpler and more regular.
Also renamed the ad-hoc version of the JSObject::HasLocalElement method not
actually returning a bool to GetLocalElementType. Now only used where really
needed.
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc
File src/elements.cc (right):
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc#newcode584
src/elements.cc:584: if (key >=
ElementsAccessorSubclass::GetCapacityImpl(backing_store))
On 2012/11/07 19:43:50, Michael Starzinger wrote:
Curly brackets around body.
Done.
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc#newcode586
src/elements.cc:586: return backing_store->get(key)->IsTheHole() ?
ABSENT : NONE;
On 2012/11/08 10:01:31, Toon Verwaest wrote:
You can probably use is_the_hole(key) here.
Done.
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc#newcode1168
src/elements.cc:1168:
On 2012/11/07 19:54:03, Michael Starzinger wrote:
Drop one of the two newlines.
Done.
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc#newcode1543
src/elements.cc:1543: // Aliased parameters and non-aliased elements in
a fast backing store
On 2012/11/07 19:43:50, Michael Starzinger wrote:
I think we can drop all three lines of comments. It adds no valuable
information
here. At least this is the wrong place to describe our crazy arguments
object
layout.
Done.
https://chromiumcodereview.appspot.com/11365111/diff/5002/src/elements.cc#newcode1551
src/elements.cc:1551: FixedArray* arguments =
FixedArray::cast(parameter_map->get(1));
On 2012/11/08 10:01:31, Toon Verwaest wrote:
Can we use a constant here? (kArgumentsIndex or so)
Just mirrored this after GetImpl, which does the same thing. :)
https://chromiumcodereview.appspot.com/11365111/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
