https://codereview.chromium.org/11365111/diff/1/src/elements.cc File src/elements.cc (right):
https://codereview.chromium.org/11365111/diff/1/src/elements.cc#newcode1472 src/elements.cc:1472: if (entry != SeededNumberDictionary::kNotFound) Curly brackets around body. https://codereview.chromium.org/11365111/diff/1/src/elements.cc#newcode1545 src/elements.cc:1545: Object* probe = key < (length - 2) ? parameter_map->get(key + 2) : NULL; Better use the GetParameterMapArg() helper for that to not duplicate this magic throughout the code. https://codereview.chromium.org/11365111/diff/1/src/elements.cc#newcode1549 src/elements.cc:1549: if (arguments->IsDictionary()) { Better delegate to the elements accessor for the underlying backing store. https://codereview.chromium.org/11365111/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
