lgtm with comments
https://codereview.chromium.org/11365111/diff/5002/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/11365111/diff/5002/src/elements.cc#newcode586 src/elements.cc:586: return backing_store->get(key)->IsTheHole() ? ABSENT : NONE; You can probably use is_the_hole(key) here. https://codereview.chromium.org/11365111/diff/5002/src/elements.cc#newcode1551 src/elements.cc:1551: FixedArray* arguments = FixedArray::cast(parameter_map->get(1)); Can we use a constant here? (kArgumentsIndex or so) https://codereview.chromium.org/11365111/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
