a few nits, mostly pedantic. I'll let Toon finish this one.
https://codereview.chromium.org/11817017/diff/18001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/11817017/diff/18001/src/arm/code-stubs-arm.cc#newcode364 src/arm/code-stubs-arm.cc:364: size += tracking_on ? AllocationSiteInfo::kSize + elements_size nit: "? AllocationSiteInfo::kSize + elements_size" on next line https://codereview.chromium.org/11817017/diff/18001/src/arm/code-stubs-arm.cc#newcode432 src/arm/code-stubs-arm.cc:432: mode = tracking_on ? COPY_ON_WRITE_ELEMENTS_WITH_ALLOCATION_SITE_INFO nit: ? on next line https://codereview.chromium.org/11817017/diff/18001/src/arm/code-stubs-arm.cc#newcode442 src/arm/code-stubs-arm.cc:442: mode = tracking_on ? CLONE_ELEMENTS_WITH_ALLOCATION_SITE_INFO nit: ? on next line https://codereview.chromium.org/11817017/diff/18001/src/arm/code-stubs-arm.cc#newcode450 src/arm/code-stubs-arm.cc:450: mode = tracking_on ? CLONE_DOUBLE_ELEMENTS_WITH_ALLOCATION_SITE_INFO nit: ? on next line https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.h#newcode448 src/code-stubs.h:448: static inline bool TrackAllocationSiteInfo(Mode mode) { nit: "Track" is a command, but you use it a query. How about ShouldTrackAllocationSiteInfo? https://codereview.chromium.org/11817017/diff/18001/src/codegen.h File src/codegen.h (right): https://codereview.chromium.org/11817017/diff/18001/src/codegen.h#newcode101 src/codegen.h:101: static void GenerateMapChangeElementsTransition(MacroAssembler* masm, nit: all parameters need to be aligned in declaration according to style guide, so param above needs to go on next line and line up with Label at the 4-char indent. https://codereview.chromium.org/11817017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
