thx for the careful look. Formatting updated (hopefully I'll remember this
stuff
better too :)).
https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h#newcode454
src/code-stubs.h:454: class LengthBits: public BitField<int, 5, 5> {};
On 2013/01/16 13:35:55, Toon Verwaest wrote:
You only need 4 bits here.
Done.
https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h#newcode457
src/code-stubs.h:457: STATIC_ASSERT(kMaximumClonedLength <= 8);
On 2013/01/16 13:35:55, Toon Verwaest wrote:
With 4 bits, this field supports < 16.
Done.
https://codereview.chromium.org/11817017/diff/39004/src/codegen.h
File src/codegen.h (right):
https://codereview.chromium.org/11817017/diff/39004/src/codegen.h#newcode99
src/codegen.h:99: // if |mode| is set to DONT_TRACK_ALLOCATION_SITE,
On 2013/01/16 13:35:55, Toon Verwaest wrote:
Uppercase I of If.
Done.
https://codereview.chromium.org/11817017/diff/39004/src/codegen.h#newcode101
src/codegen.h:101: static void
GenerateMapChangeElementsTransition(MacroAssembler* masm,
On 2013/01/16 13:35:55, Toon Verwaest wrote:
In function declarations, put the arguments right below each other:
static void GenerateMap...(MacroAssembler* masm,
AllocationSiteMode mode,
Label* allocation_site_info_found);
Done, and updated the two functions below to have the same style.
However, I have to indent the lines of the
GenerateMapChangeElementsTransition arguments because they are too long
for the 80 column character limit.
https://codereview.chromium.org/11817017/diff/39004/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/11817017/diff/39004/src/ia32/lithium-codegen-ia32.cc#newcode5303
src/ia32/lithium-codegen-ia32.cc:5303: AllocationSiteMode
allocation_site_mode = instr->hydrogen()->
On 2013/01/16 13:35:55, Toon Verwaest wrote:
AllocationSiteMode allocation_site_mode =
intr->hydrogen()->allocation_site_mode();
Done.
https://codereview.chromium.org/11817017/diff/39004/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/11817017/diff/39004/src/objects.cc#newcode7527
src/objects.cc:7527: && (IsFastObjectElementsKind(to) ||
IsFastDoubleElementsKind(to))) {
On 2013/01/16 13:35:55, Toon Verwaest wrote:
&& on previous line. I'd also break the line between
FLAG_track_allocation_sites
and IsFastSmiElementsKind.
Done.
https://codereview.chromium.org/11817017/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
