Toon did a review, I typed the comments. jeesh.
https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.cc#newcode599 src/code-stubs.cc:599: // transition. Better, pass a parameter to the method indicating track/don'ttrack (AllocationSiteInfoMode). And in as many places as possible, discover this with a helper method that hides: 1) the flag 2) to, from elements kind 3) other dynamic cases...e.tc. https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/11817017/diff/18001/src/code-stubs.h#newcode427 src/code-stubs.h:427: CLONE_ELEMENTS_WITH_ALLOCATION_SITE_INFO, Instead, use a bitfield that combines the AllocationSiteInfoMode with the FastCloneShallowArrayStub::Mode. https://codereview.chromium.org/11817017/diff/18001/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://codereview.chromium.org/11817017/diff/18001/src/ia32/ic-ia32.cc#newcode849 src/ia32/ic-ia32.cc:849: ElementsTransitionGenerator::GenerateMapChangeElementsTransition(masm, slow); Rename this parameter to handle_transition_in_runtime. https://codereview.chromium.org/11817017/diff/18001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/11817017/diff/18001/src/ia32/lithium-codegen-ia32.cc#newcode5344 src/ia32/lithium-codegen-ia32.cc:5344: : FastCloneShallowArrayStub::CLONE_ELEMENTS; Please put this in hydrogen-instructions just like what was done for HFastLiteral (in fact move the key up to the base class HMaterializedLiteral). AND reverse this logic anyway. https://codereview.chromium.org/11817017/diff/18001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11817017/diff/18001/src/objects.cc#newcode10438 src/objects.cc:10438: ElementsKindToString(to_kind)); spaces between 8*1024. also AllocationSiteInfo->Print(). https://codereview.chromium.org/11817017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
