LGTM with some last, mostly style-related, nits.
https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h#newcode454 src/code-stubs.h:454: class LengthBits: public BitField<int, 5, 5> {}; You only need 4 bits here. https://codereview.chromium.org/11817017/diff/39004/src/code-stubs.h#newcode457 src/code-stubs.h:457: STATIC_ASSERT(kMaximumClonedLength <= 8); With 4 bits, this field supports < 16. https://codereview.chromium.org/11817017/diff/39004/src/codegen.h File src/codegen.h (right): https://codereview.chromium.org/11817017/diff/39004/src/codegen.h#newcode99 src/codegen.h:99: // if |mode| is set to DONT_TRACK_ALLOCATION_SITE, Uppercase I of If. https://codereview.chromium.org/11817017/diff/39004/src/codegen.h#newcode101 src/codegen.h:101: static void GenerateMapChangeElementsTransition(MacroAssembler* masm, In function declarations, put the arguments right below each other: static void GenerateMap...(MacroAssembler* masm, AllocationSiteMode mode, Label* allocation_site_info_found); https://codereview.chromium.org/11817017/diff/39004/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/11817017/diff/39004/src/ia32/lithium-codegen-ia32.cc#newcode5303 src/ia32/lithium-codegen-ia32.cc:5303: AllocationSiteMode allocation_site_mode = instr->hydrogen()-> AllocationSiteMode allocation_site_mode = intr->hydrogen()->allocation_site_mode(); https://codereview.chromium.org/11817017/diff/39004/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11817017/diff/39004/src/objects.cc#newcode7527 src/objects.cc:7527: && (IsFastObjectElementsKind(to) || IsFastDoubleElementsKind(to))) { && on previous line. I'd also break the line between FLAG_track_allocation_sites and IsFastSmiElementsKind. https://codereview.chromium.org/11817017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
