Quick drive-by-comments...
https://codereview.chromium.org/15943002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/api.cc#newcode6161
src/api.cc:6161: #define DATA_VIEW_GETTER(FunctionName, TypeName)
\
Don't duplicate tons of code here, just make swizzling a byte a no-op
and do things consistently. Furthermore, can't we use templates somehow
instead of this macro-horror?
https://codereview.chromium.org/15943002/diff/1/src/api.cc#newcode6197
src/api.cc:6197: #define DATA_VIEW_SETTER(FunctionName, TypeName)
\
Same here.
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc#newcode765
src/objects-debug.cc:765: CHECK(byte_offset()->IsSmi() ||
byte_offset()->IsHeapNumber()
Use IsNumber() here and below.
https://codereview.chromium.org/15943002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/runtime.cc#newcode802
src/runtime.cc:802: #define DATA_VIEW_GETTER(getter, accessor)
\
Whatever you do, we shouldn't land this with pages of duplicated code.
https://codereview.chromium.org/15943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
