https://codereview.chromium.org/15943002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/api.cc#newcode6161
src/api.cc:6161: #define DATA_VIEW_GETTER(FunctionName, TypeName)
\
On 2013/05/24 06:58:25, Sven Panne wrote:
Don't duplicate tons of code here, just make swizzling a byte a no-op
and do
things consistently.
That means adding a `bool little_endian` to the GetInt8() and GetUint8()
API functions which seems kind of weird. Your call.
Furthermore, can't we use templates somehow instead of this
macro-horror?
I don't see how unless it's moved to v8.h - but that means Swizzle() and
IsLittleEndian() have to move as well.
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc#newcode765
src/objects-debug.cc:765: CHECK(byte_offset()->IsSmi() ||
byte_offset()->IsHeapNumber()
On 2013/05/24 06:58:25, Sven Panne wrote:
Use IsNumber() here and below.
Why is that? I ask because JSArrayBufferVerify() uses the same check.
https://codereview.chromium.org/15943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
