https://codereview.chromium.org/15943002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/api.cc#newcode6214
src/api.cc:6214: #define DATA_VIEW_SETTER_SWIZZLE(FunctionName,
TypeName) \
Can't we make this macro a template and simply delegate to it? No
duplication, no macros, no need to have a swizzle flag externally
visible. Same for getters, of course.
https://codereview.chromium.org/15943002/diff/1/src/api.cc#newcode6233
src/api.cc:6233: DATA_VIEW_GETTER(GetInt8, int8_t)
These and the following lines would simply delegate without any macro
trickery, as mentioned above. Templates *are* macros, after all. :-)
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/15943002/diff/1/src/objects-debug.cc#newcode765
src/objects-debug.cc:765: CHECK(byte_offset()->IsSmi() ||
byte_offset()->IsHeapNumber()
Never mind, I see that IsNumber() is just IsSmi() || IsHeapNumber().
Want me to
update JSArrayBufferVerify() as well?
This would be nice.
https://codereview.chromium.org/15943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
