As discussed with Took off the bug it could make sense to change
InvokeAccessorGetter/InvokeAccessorGetterCallback signatures in ic.cc to use
internal instead of public types but it would just add unnecessary
conversions
and more importantly there are no internal counterparts for
v8::AccessorInfo and
v8::AccessorGetter. Since it would be a mix of public and private types I'd
rather leave it as is. Here is how it would look like with internal types
https://codereview.chromium.org/16171016/diff/2001/src/ic.cc I'll update
this
change if you prefer those signatures.
Another thing that we discussed was sharing common code between
JSObject::GetPropertyWithCallback that works in slow case and the new
functions.
PropertyCallbackArguments::Call used to invoke external callback is
generated by
a macro and I cannot change it just for AccessorGetter property as the same
macro is used for other API callbacks accepting 2 parameters. I'd rather
change
PropertyCallbackArguments::Call so that it take care of creating
VMState<EXTERNAL> and ExternalCallbackScope but in a separate CL.
https://codereview.chromium.org/16286016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
