I _really_ like the direction this is going.
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc#newcode2164
src/arm/lithium-codegen-arm.cc:2164: int left_block =
instr->TrueDestination(chunk_);
Why this unrelated change?
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs-hydrogen.cc#newcode769
src/code-stubs-hydrogen.cc:769:
minus->AssumeRepresentation(Representation::Double());
Try to move this out with the other representation changes so that this
code can be shared 100% with hydrogen.
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs-hydrogen.cc#newcode781
src/code-stubs-hydrogen.cc:781: UnaryOpStub* stub = casted_stub();
Please share this code with hydrogen, it should be identical to the
inlined instructions in the optimized code. We do this for other stubs
by putting
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs-hydrogen.cc#newcode802
src/code-stubs-hydrogen.cc:802: AddInstruction(new(zone())
HCheckSmi(input));
Try to avoid the explicit checks by using force representation here and
below for double.
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs.cc#newcode214
src/code-stubs.cc:214:
nit: two empty lines, please
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs.cc#newcode227
src/code-stubs.cc:227: void UnaryOpStub::Record(Handle<Object> object) {
UpdateState?
https://codereview.chromium.org/17229005/diff/23028/src/code-stubs.cc#newcode242
src/code-stubs.cc:242:
nit: two spaces between functions
https://codereview.chromium.org/17229005/diff/23028/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/ic.cc#newcode2479
src/ic.cc:2479:
nit: two lines between functions
https://codereview.chromium.org/17229005/diff/23028/src/ic.cc#newcode2484
src/ic.cc:2484: stub.Record(object);
Can you change "Record" here and elsewhere to UpdateState()?
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
