On 2013/06/21 18:32:38, Rodolph Perfetta wrote:
drive by comments on ARM.
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-arm.cc#newcode2036
src/arm/lithium-arm.cc:2036: LOperand* value = UseAtStart(instr->value());
Shouldn't this be UseRegisterAtStart?
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc#newcode2199
src/arm/lithium-codegen-arm.cc:2199: __ ldr(ip, FieldMemOperand(reg,
HeapObject::kMapOffset));
ip shouldn't be used outside the macro assembler. CompareRoot below will
use
ip
as a temp register to do the compare so in the end you will always branch
(or
assert in debug).
Lithium has a dedicated scratch register: scratch0() which you can use
instead.
ok, thanks for the helpful dbc
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
