On 2013/06/21 16:38:04, danno wrote:

https://codereview.chromium.org/17229005/diff/23028/src/arm/lithium-codegen-arm.cc#newcode2164
src/arm/lithium-codegen-arm.cc:2164: int left_block =
instr->TrueDestination(chunk_);
Why this unrelated change?

neurosis?
it bothered me, that the definition of the variables did have the opposite order
than the method arguments :)

Try to move this out with the other representation changes so that this code
can
be shared 100% with hydrogen.

ok


https://codereview.chromium.org/17229005/diff/23028/src/code-stubs.cc#newcode227
src/code-stubs.cc:227: void UnaryOpStub::Record(Handle<Object> object) {
UpdateState?

better indeed

PTAL

https://codereview.chromium.org/17229005/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to